test: Speed up the unit, integration and E2E test suites - #1106
Merged
Conversation
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1106 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 51 51
Lines 3445 3445
=======================================
Hits 3190 3190
Misses 255 255
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
August 27, 2026 09:57
Pijukatel
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI critical path is the E2E job at ~5.9 min; it and the unit suite mostly wait rather than work (master run
32966697702).E2E
sdk_wheel_pathlocks the wheel build on a shared file, but keeps the "already built" marker under the per-workergetbasetemp(), so all 16 workers rebuild the wheel in turn behind the lock (first worker's first test at 41s, last at 144s). The marker moves next to the lock, into the shared parent dir.test_crawlee/test_scrapyhold the 6 slowest tests but collect last, and xdist distributes in collection order -test_adaptive_playwright_crawler(167s) ran t=155s to 322s, ~100s after every other worker went idle. Apytest_collection_modifyitemshook puts them first.Unit
test_reboot_proceeds_when_event_listener_exceeds_timeout: 30.1s of 80.5s, because its listener slept 60s and leaving theActorcontext waited outcleanup_timeout. It releases the listener viaasyncio.Eventinstead (-> 0.17s).os.utime.tests_concurrency1 -> 4 (the suite ran at ~21% CPU on one worker), plus--dist workstealso a worker that draws several slow tests stops being the critical path.Locally 81.0s -> 15.5s at 4 workers, 572 passing. Projected CI: unit ~2 -> ~1 min, E2E 5.9 -> ~4 min. E2E is unverified locally (no platform token), so the first CI run is the check.
✍️ Drafted by Claude Code